[Routing] fix route loading with wildcard, but dir or file is empty #34024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a bug fix it needs to be opened against 3.4 |
|
Also the XmlFileLoader would need the same bug fix. |
nicolas-grekas
approved these changes
Oct 19, 2019
nicolas-grekas
force-pushed
the
fix-import-routes-with-empty-wildcard
branch
from
5a8fb7c
to
217058b
Compare
|
Thank you @gseidel. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 19, 2019
… is empty (gseidel)
This PR was merged into the 4.3 branch.
Discussion
----------
[Routing] fix route loading with wildcard, but dir or file is empty
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | no ticket i see so far
| License | MIT
In my route config i have something like:
```yaml
empty_wildcard:
resource: ../controller/empty_wildcard/*
prefix: /empty_wildcard
```
But ``empty_wildcard`` is empty or has no route configured.
So i had this error:
``Call to a member function addPrefix() on null``
This PR take care if no route is configured, there will be no error.
Commits
-------
217058b [Routing] fix route loading with wildcard, but dir or file is empty
nicolas-grekas
added a commit
that referenced
this pull request
Oct 19, 2019
… is empty (gseidel)
This PR was merged into the 4.3 branch.
Discussion
----------
[Routing] fix route loading with wildcard, but dir or file is empty
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | no ticket i see so far
| License | MIT
In my route config i have something like:
```yaml
empty_wildcard:
resource: ../controller/empty_wildcard/*
prefix: /empty_wildcard
```
But ``empty_wildcard`` is empty or has no route configured.
So i had this error:
``Call to a member function addPrefix() on null``
This PR take care if no route is configured, there will be no error.
Commits
-------
217058b [Routing] fix route loading with wildcard, but dir or file is empty
nicolas-grekas
added a commit
that referenced
this pull request
Oct 19, 2019
* 3.4: bug #34024 [Routing] fix route loading with wildcard, but dir or file is empty (gseidel)
|
Applied on 3.4 in a54ecb0 |
fabpot
added a commit
that referenced
this pull request
Oct 20, 2019
* 4.3: [HttpKernel] fix wrong removal of the just generated container dir bug #34024 [Routing] fix route loading with wildcard, but dir or file is empty (gseidel) [Routing] fix route loading with wildcard, but dir or file is empty
fabpot
added a commit
that referenced
this pull request
Oct 20, 2019
* 4.4: [HttpKernel] fix wrong removal of the just generated container dir bug #34024 [Routing] fix route loading with wildcard, but dir or file is empty (gseidel) [Routing] fix route loading with wildcard, but dir or file is empty bump Form component compatibility versions execute all compatible tests across versions [Mailer][MailchimpBridge] Fix NamedAddress obsolete paths
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my route config i have something like:
But
empty_wildcardis empty or has no route configured.So i had this error:
Call to a member function addPrefix() on nullThis PR take care if no route is configured, there will be no error.