Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Add DateTimeZoneNormalizer into Dependency Injection #34546

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

jewome62
Copy link
Contributor

@jewome62 jewome62 commented Nov 23, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets none
License MIT
Doc PR none

#30915
I have forgot to add new Normalizer into DI 🤭

#SymfonyHackday

@jewome62 jewome62 changed the title Add DateTimeZoneNormalizer into Dependency Injection [Serializer] Add DateTimeZoneNormalizer into Dependency Injection Nov 23, 2019
@jewome62
Copy link
Contributor Author

Appveyor CI fail is not related to this PR

@nicolas-grekas
Copy link
Member

Shouldn't this target 4.4?

@xabbuh
Copy link
Member

xabbuh commented Nov 23, 2019

If we treat this as a bugfix, it must be merged into the 4.3 branch where the DateTimeZoneNormalizer was added.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Nov 24, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.3 LGTM

@fabpot
Copy link
Member

fabpot commented Nov 24, 2019

Thank you @jewome62.

fabpot added a commit that referenced this pull request Nov 24, 2019
…jection (jewome62)

This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #34546).

Discussion
----------

[Serializer] Add DateTimeZoneNormalizer into Dependency Injection

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | none

#30915
I have forgot to add new Normalizer into DI 🤭

#SymfonyHackday

Commits
-------

1a81dd7 Add DateTimeZoneNormalizer into Dependency Injection
@fabpot fabpot merged commit 1a81dd7 into symfony:4.3 Nov 24, 2019
@jewome62 jewome62 deleted the add-normalizer-to-DI branch November 25, 2019 11:50
This was referenced Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants