[DI] Fix making the container path-independent when the app is in /app #34757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Dec 2, 2019
fabpot
approved these changes
Dec 2, 2019
nicolas-grekas
force-pushed
the
di-fix-path
branch
from
c6f46c3
to
88d0da4
Compare
nicolas-grekas
force-pushed
the
di-fix-path
branch
from
88d0da4
to
b33b9a6
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 2, 2019
…p is in /app (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix making the container path-independent when the app is in /app | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34750, Fix #34611 | License | MIT | Doc PR | - Right now, we mandate the app to be nested in a directory of level 2 minimum. This means apps cannot be made path-independent if they are built in e.g. `/app`. Commits ------- b33b9a6 [DI] Fix making the container path-independent when the app is in /app
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we mandate the app to be nested in a directory of level 2 minimum. This means apps cannot be made path-independent if they are built in e.g.
/app.