Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix making the container path-independent when the app is in /app #34757

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34750, Fix #34611
License MIT
Doc PR -

Right now, we mandate the app to be nested in a directory of level 2 minimum. This means apps cannot be made path-independent if they are built in e.g. /app.

@stof
stof approved these changes Dec 2, 2019
@fabpot
fabpot approved these changes Dec 2, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-fix-path branch from c6f46c3 to 88d0da4 Dec 2, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-fix-path branch from 88d0da4 to b33b9a6 Dec 2, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 2, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Dec 2, 2019
…p is in /app (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix making the container path-independent when the app is in /app

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34750, Fix #34611
| License       | MIT
| Doc PR        | -

Right now, we mandate the app to be nested in a directory of level 2 minimum. This means apps cannot be made path-independent if they are built in e.g. `/app`.

Commits
-------

b33b9a6 [DI] Fix making the container path-independent when the app is in /app
@fabpot fabpot merged commit b33b9a6 into symfony:3.4 Dec 2, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 5, 2019
nicolas-grekas referenced this pull request Dec 10, 2019
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-path branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.