[HttpFoundation] fix redis multi host dsn not recognized #34967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/SessionHandlerFactory.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Dec 13, 2019
nicolas-grekas
changed the title
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
bugfix/fix-redis-cluster-dsn
branch
from
d2b0568
to
81ba07a
Compare
|
Thank you @WhiteRabbitDE. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2019
…Jan Christoph Beyer) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] fix redis multi host dsn not recognized | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34477 | License | MIT #34177 added support configurating session handlers with DSNs. It was no possible to pass a redis-DSN like `redis:?host[localhost]&host[localhost:6379]&host[/var/run/redis.sock:]&auth=my-password&redis_cluster=1'` since the check was `case 0 === strpos($connection, 'redis://'):` Commits ------- 81ba07a fix redis multi host dsn not recognized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34177 added support configurating session handlers with DSNs. It was no possible to pass a redis-DSN like
redis:?host[localhost]&host[localhost:6379]&host[/var/run/redis.sock:]&auth=my-password&redis_cluster=1'since the check was
case 0 === strpos($connection, 'redis://'):