[HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN #34177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Oct 29, 2019
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/SessionHandlerFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/SessionHandlerFactory.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
hf-session-dsn
branch
from
016cfab
to
d166834
Compare
nicolas-grekas
force-pushed
the
hf-session-dsn
branch
from
d166834
to
de9c61f
Compare
fabpot
approved these changes
Oct 30, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2019
…e session handler with a DSN (nicolas-grekas)
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
```yaml
framework:
session:
handler_id: 'redis://localhost'
handler_id: '%env(REDIS_URL)%'
handler_id: '%env(DATABASE_URL)%'
handler_id: 'file://%kernel.project_dir%/var/sessions'
```
etc.
the database connection is not shared with the ORM (don't mess with transactions.)
redis/memcached connections are shared between cache and session.
(as a reminder, cache and ORM share the db connection: we're ok with trashing the cache on a rollback)
Lock-related changes are a follow up of #34043.
(fabbot failure is false positive)
Commits
-------
de9c61f [HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN
This was referenced Nov 12, 2019
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2019
…Jan Christoph Beyer) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] fix redis multi host dsn not recognized | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34477 | License | MIT #34177 added support configurating session handlers with DSNs. It was no possible to pass a redis-DSN like `redis:?host[localhost]&host[localhost:6379]&host[/var/run/redis.sock:]&auth=my-password&redis_cluster=1'` since the check was `case 0 === strpos($connection, 'redis://'):` Commits ------- 81ba07a fix redis multi host dsn not recognized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etc.
the database connection is not shared with the ORM (don't mess with transactions.)
redis/memcached connections are shared between cache and session.
(as a reminder, cache and ORM share the db connection: we're ok with trashing the cache on a rollback)
Lock-related changes are a follow up of #34043.
(fabbot failure is false positive)