Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] add test case for wordwrap method #35236

Merged
merged 12 commits into from Jan 9, 2020

Conversation

@mgamal92
Copy link
Contributor

mgamal92 commented Jan 6, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

Just test case for wordwrap method

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jan 7, 2020
Copy link
Member

nicolas-grekas left a comment

I think this deserves a few more input/output.
The logic of wordwrap is more than just replacing a space by a dash :)

Copy link
Member

nicolas-grekas left a comment

LGTM, just minor issues remaining (see fabbot report)

@mgamal92

This comment has been minimized.

Copy link
Contributor Author

mgamal92 commented Jan 7, 2020

i've fixed these issues :)

@mgamal92 mgamal92 requested a review from nicolas-grekas Jan 7, 2020
mpdude and others added 10 commits Jan 8, 2020
… passthru() commands fails (mpdude)

This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

[PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Some commands executed by the `simple-phpunit` script are not checked for success. For example [here](https://travis-ci.org/twigphp/Twig/jobs/634110681), Composer fails with the message

```
  [InvalidArgumentException]
  Could not find package phpunit/phpunit with version 7.5.* in a version inst
  allable using your PHP version 7.0.25.
```

Yet, the `simple-phpunit` script happily continues, going over failing `chdir()`, `file_get_contents()` and `include()` calls and eventually returns a successful `0` exit code. So CI tests look OK when in fact PHPUnit was not even downloaded.

Commits
-------

576e185 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
…to be resource (plozmun)

This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

[PHPUnitBridge] file_get_contents() expects parameter 3 to be resource

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

file_get_contents 3rd parameter (context) expects resource or NULL to ignore them

Commits
-------

a28a421 [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
This PR was merged into the 4.3 branch.

Discussion
----------

[Process] - update @throws phpdoc

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        |

Update PHPDoc throws Exceptions on https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Process/Process.php

Commits
-------

2be7029 [Process] - update @throws phpdoc
* 3.4:
  [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
  [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
* 4.3:
  [Process] - update @throws phpdoc
  [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
  [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel][FileLocator] Fix deprecation message

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Ref #34886

`$deprecatedPath` is the foreach value so it only works if the last element triggers the deprecation, otherwise the value is wrong.

Commits
-------

18ce839 [HttpKernel][FileLocator] Fix deprecation message
* 4.4:
  [Process] - update @throws phpdoc
  [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
  [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
  [HttpKernel][FileLocator] Fix deprecation message
@nicolas-grekas nicolas-grekas changed the base branch from master to 5.0 Jan 9, 2020
@nicolas-grekas nicolas-grekas force-pushed the mgamal92:test_for_wordwrap branch from 03d72b5 to c314598 Jan 9, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 9, 2020

Thank you @mgamal92.

nicolas-grekas added a commit that referenced this pull request Jan 9, 2020
This PR was submitted for the master branch but it was squashed and merged into the 5.0 branch instead.

Discussion
----------

[String] add test case for wordwrap method

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

Just test case for ```wordwrap``` method

Commits
-------

c314598 [String] add test case for wordwrap method
@nicolas-grekas nicolas-grekas merged commit c314598 into symfony:5.0 Jan 9, 2020
0 of 3 checks passed
0 of 3 checks passed
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.