Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Added a way to not fire the announce event #35322

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 13, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #35286
License MIT
Doc PR symfony/symfony-docs#12942

@lyrixx lyrixx changed the title [Workflow] Added a way to not fire the annonce event [Workflow] Added a way to not fire the announce event Jan 13, 2020
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :)

Copy link
Contributor

@Harry-Dunne Harry-Dunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

lyrixx added a commit that referenced this pull request Jan 14, 2020
…(lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Workflow] Added a way to not fire the announce event

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35286
| License       | MIT
| Doc PR        |

Commits
-------

d31939d [Workflow] Added a way to not fire the annonce event
@lyrixx lyrixx merged commit d31939d into symfony:master Jan 14, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
@lyrixx lyrixx deleted the w-announce branch December 15, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow] ANNOUNCE event should be optional
7 participants