[FrameworkBundle] Deprecate some public services to private #36691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please update for 5.2? |
fancyweb
force-pushed
the
fwb-deprecate-public-services-1
branch
2 times, most recently
from
cf659dd
to
fa99591
Compare
fancyweb
force-pushed
the
fwb-deprecate-public-services-1
branch
from
fa99591
to
1fd14ff
Compare
|
@nicolas-grekas Should I split this PR service by service to ease the review? |
|
No need to split IMO. But this should wait on #37186 due to all the conflicts. |
|
Time for rebase :) |
fancyweb
force-pushed
the
fwb-deprecate-public-services-1
branch
from
1fd14ff
to
805c71d
Compare
fancyweb
force-pushed
the
fwb-deprecate-public-services-1
branch
from
805c71d
to
87868ba
Compare
fabpot
approved these changes
Jul 31, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Aug 12, 2020
…ogizanagi) This PR was merged into the 5.2-dev branch. Discussion ---------- [FrameworkBundle] Fix 7.4 CachePools integration tests | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | #36691 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | N/A Attempt to fix https://github.com/symfony/symfony/runs/975252922#step:11:56 on master. Commits ------- d3ef8ba [FrameworkBundle] Fix 7.4 CachePools integration tests
Merged
fabpot
added a commit
that referenced
this pull request
Apr 18, 2021
…(fancyweb) This PR was merged into the 5.3-dev branch. Discussion ---------- [SecurityBundle] Deprecate public services to private | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - Follow up of #36691 on the SecurityBundle Commits ------- 56be86a [SecurityBundle] Deprecate public services to private
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Apr 18, 2021
…(fancyweb) This PR was merged into the 5.3-dev branch. Discussion ---------- [SecurityBundle] Deprecate public services to private | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#36691 on the SecurityBundle Commits ------- 56be86aa7d [SecurityBundle] Deprecate public services to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can deprecate public services to private, here is a first pass on the FWB. I think all those services don't need to be public, ie we never need to access them directly in Symfony's code (except in some tests that I had to modify accordingly). I think most of theses services needed to be public before we hooked the AbstractController with a service subscriber. There are definitely more of them that can be deprecated (ie: created workflows and state machines are public but don't need to be ?) but let's start with the easy ones.