[FrameworkBundle] WebTestCase createClient doesn't check if static:kernel was already allocated #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +164,7 @@ protected function tearDown() | |||
| { | |||
| if (null !== static::$kernel) { | |||
| static::$kernel->shutdown(); | |||
| static::$kernel = null; | |||
There was a problem hiding this comment.
This should be removed. We reuse the same kernel for all requests.
|
Can you squash your commits before I merge? Thanks. |
|
Done. |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2012
…3704) Commits ------- 3303155 added kernel shutdown before create client, fixed and stashed Discussion ---------- [FrameworkBundle] WebTestCase createClient doesn't check if static:kernel was already allocated with this little fix CreateClient shuts down the kernel before booting again. If you add an echo after the "if" on the line number 38 and run the test you would see that sometime the kernel is not properly umounted. Bug fix: [no] Feature addition: [no] Backwards compatibility break: [no] Symfony2 tests pass: [yes] --------------------------------------------------------------------------- by fabpot at 2012-03-29T09:19:07Z Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by liuggio at 2012-03-29T10:17:59Z Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this little fix CreateClient shuts down the kernel before booting again.
If you add an echo after the "if" on the line number 38
and run the test you would see that sometime the kernel is not properly umounted.
Bug fix: [no]
Feature addition: [no]
Backwards compatibility break: [no]
Symfony2 tests pass: [yes]