Move event alias mappings to their components #37295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/move-event-aliases
branch
from
fff41d7
to
0c93d78
Compare
derrabus
force-pushed
the
improvement/move-event-aliases
branch
4 times, most recently
from
96ed21e
to
f9df6e2
Compare
wouterj
approved these changes
Jun 29, 2020
nicolas-grekas
approved these changes
Jun 30, 2020
derrabus
force-pushed
the
improvement/move-event-aliases
branch
from
f9df6e2
to
28e6f6f
Compare
|
The failure on Travis looks unrelated. |
fabpot
approved these changes
Jul 1, 2020
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a small console tool, I wanted to use the Console, EventDispatcher and DI components standalone. In order to make use of aliased events, I had to copy over the mapping information from FrameworkBundle, which was a bit unfortunate.
With this PR, I'd like to suggest to store all alias mappings on the
*Eventsclasses of each component instead. This change will make the mapping reusable outside of the full-stack framework.Note: I've bumped the dependencies of FrameworkBundle/SercurityBundle in order to gain access to the moved mapping information. If any of the bumps is too heavy, please tell me and I'll implement a fallback instead.