Allow Drupal to wrap the Symfony test listener (5.1 backport) #38031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpott
changed the title
| $parsedMsg = unserialize($this->message); | ||
| restore_error_handler(); | ||
| set_error_handler(function () {}); | ||
| $parsedMsg = @unserialize($this->message); |
There was a problem hiding this comment.
the `@ is not required anymore since the error handler ignores everything
There was a problem hiding this comment.
It's in master - that's why I added it back.
There was a problem hiding this comment.
I'll remove it here and submit a PR to clean up master.
There was a problem hiding this comment.
Created #38033 to address this in master.
This reverts commit ee8cc26.
nicolas-grekas
approved these changes
Sep 2, 2020
fabpot
approved these changes
Sep 2, 2020
|
Thank you @alexpott. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2020
…e TestsListener (fancyweb) This PR was merged into the 5.1 branch. Discussion ---------- [PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #38031 caused an unwanted regression: if the frame `class` matches `SymfonyTestsListenerFor` it used to always return, now it continues so the `originClass` and `originMethod` properties are set. Therefore, the deprecation is considered as coming from the test listener. It ends up in the "legacy" group and muted because the test listeners contains the word "Legacy" in their namespaces. Example test: ```php <?php namespace App\Tests; use PHPUnit\Framework\TestCase; use Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher; final class FooTest extends TestCase { public function test(): void { // ExtractingEventDispatcher is @internal new class extends ExtractingEventDispatcher {}; $this->assertTrue(true); } } ``` On 4.4: ``` Other deprecation notices (1) 1x: The "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher" class is considered internal. It may change without further notice. You should not use it from "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher@anonymous". ``` On 5.1: ``` Legacy deprecation notices (1) ``` Commits ------- 1ba06a0 [PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #37708