Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint #39856

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint #39856

merged 1 commit into from
Aug 26, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 16, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #33551, #37757
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.x milestone Jan 16, 2021
@xabbuh xabbuh mentioned this pull request Jan 16, 2021
Closed
@xabbuh xabbuh force-pushed the issue-33551 branch 2 times, most recently from 68b81cb to fc80015 Compare January 16, 2021 13:24
@nicolas-grekas
Copy link
Member

This will need a PR on lower branches, to relax the assertions when fwb is used with domcrawler ^5.3

@xabbuh
Copy link
Member Author

xabbuh commented Jan 19, 2021

That's true, the alternative would be to merge this in a lower branch. But since this is not a bugfix I think we should not do that.

@fabpot
Copy link
Member

fabpot commented Feb 5, 2021

If that's easier for us, let's do that change in 4.4?

@xabbuh xabbuh changed the base branch from 5.x to 4.4 February 5, 2021 09:54
@xabbuh xabbuh force-pushed the issue-33551 branch 3 times, most recently from 8492fd1 to 6cdd8d6 Compare February 8, 2021 11:47
@xabbuh
Copy link
Member Author

xabbuh commented Feb 9, 2021

rebased on 4.4

@xabbuh xabbuh modified the milestones: 5.x, 4.4 Feb 26, 2021
@fabpot
Copy link
Member

fabpot commented Aug 26, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit 3ff5db6 into symfony:4.4 Aug 26, 2021
This was referenced Aug 30, 2021
Merged
Merged
@xabbuh xabbuh deleted the issue-33551 branch October 5, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
DomCrawler Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Could assertSelectorTextContains return current value in WebTestCase?
4 participants
@xabbuh @nicolas-grekas @fabpot @carsonbot