Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finder] Fixes in the iterators #4028

Merged
merged 1 commit into from
Apr 20, 2012
Merged

[Finder] Fixes in the iterators #4028

merged 1 commit into from
Apr 20, 2012

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 20, 2012

fix: #4023
ref: #4011

  • Fix regex detection
  • call file_get_contents() only once (vs once per pattern)

Build Status

@gajdaw thoughts ?

fabpot added a commit that referenced this pull request Apr 20, 2012
Commits
-------

f728463 [Finder] Fixes in the iterators

Discussion
----------

[Finder] Fixes in the iterators

fix: #4023
ref: #4011

- Fix regex detection
- call `file_get_contents()` only once (vs once per pattern)

[![Build Status](https://secure.travis-ci.org/vicb/symfony.png?branch=finder/regex)](http://travis-ci.org/vicb/symfony)

@gajdaw thoughts ?
@fabpot fabpot merged commit f728463 into symfony:master Apr 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Finder] Fix regexp detection in FileContentFilterIterator
2 participants