[FrameworkBundle] Deprecate creating public workflow services #40875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Apr 19, 2021
fancyweb
commented
Apr 19, 2021
src/Symfony/Bundle/FrameworkBundle/Resources/config/workflow.php
Outdated
Show resolved
Hide resolved
fancyweb
commented
Apr 19, 2021
fancyweb
force-pushed
the
fwb/deprecate-workflow-abstract-public
branch
from
b22b383
to
e6f599a
Compare
nicolas-grekas
approved these changes
Apr 20, 2021
fancyweb
force-pushed
the
fwb/deprecate-workflow-abstract-public
branch
from
e6f599a
to
79cbf00
Compare
lyrixx
approved these changes
Apr 20, 2021
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, workflow services don't need to be public. friendly ping to @lyrixx as a reviewer.