[Debug][ErrorHandler] Do not use the php80 polyfill

[nicolas-grekas]

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

[stof]

the usage of get_debug_type in FatalThrowableError also seems to cause issues (see the Goutte issue referencing that ticket)

[derrabus]

Out of curiosity: What's the problem with using the polyfill here?

[stof]

@derrabus polyfills rely on autoloading (for the internal class). So this breaks if the polyfill is called inside the autoloading stack (as autoloading the polyfill internal classes will also try to use them then).
For the error handling part, I suspect it is similar (for cases where an error happens during the error handling or during the autoloading of the polyfill internals)

[Tobion]

Shouldn't this remove the polyfill-php80 dependency from composer.json then?

[Nyholm]

I dont see us using any PHP8-only code in the ErrorHandler. I agree with @Tobion

With that change, Im 👍

[nicolas-grekas]

Polyfill now removed (we were using a few calls to get_debug_type(), now removed).

[Tobion]

I guess we could revert this in 6.0 as it will require php 8?

[stof]

@Tobion yes (but without re-adding the polyfill package)

[nicolas-grekas]

I did revert while merging up.