[4.4] Add missing @return annotations
#42246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
jderusse,
xabbuh and
yceruto
as code owners
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2021
This PR was merged into the 5.2 branch. Discussion ---------- [5.2] Add missing ``@return`` annotations | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #42246 for 5.2 Commits ------- 7c10e09 [5.2] Add missing ``@return`` annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These annotations are needed to notify that the return is going to change because a parent class/interface is already advertising that (eg using PHP 8.1's tentative return types).
We should add the
#[ReturnTypeWillChange]attribute on many of those methods, butDebugClassLoaderis not ready to do it yet.