[HttpFoundation] Fixed type mismatch

[Toflar]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	#42290
License	MIT
Doc PR	-

Fixes

Argument 1 passed to str_contains() must be of the type string, null given, called in /.../vendor/symfony/http-foundation/Response.php on line 327

in case there's no cache-control response header. This doesn't happen by default as the Response is initialized with one by default but any class extending from it can adjust that. Technically speaking, it's not disallowed to have no cache-control header set.

Want me to add a test for that? :)

[derrabus]

Want me to add a test for that?

Sure, why not. 🙂

[Toflar]

That was kind of a stupid question, I was just being lazy 🙈 Test is here now :)

[derrabus]

Thank you @Toflar.

[metaer]

What about 5.3 branch? Is this patch going to be applied to 5.3?

[derrabus]

Yes.

[bobvandevijver]

I guess this can be reverted, as it was actually a bug with the str_contains polyfill, which just released a new version containing a fix: https://github.com/symfony/polyfill/releases/tag/v1.23.1

[derrabus]

@bobvandevijver Actually, we need this change again for PHP 8.1 as passing null will trigger a deprecation warning there. I think, we're good.

[bobvandevijver]

@derrabus Ok, but in that case #42300 should probably still be fixed right?

[derrabus]

Yes. Up for a PR? 🙂

[bobvandevijver]

Done! See #42316 & #42317 😃

[COil]

Thanks for the fix. I also had this error with Sf 5.3.5. 😉