[Notifier] Update FirebaseTransport.php #43073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Sep 17, 2021
src/Symfony/Component/Notifier/Bridge/Firebase/FirebaseTransport.php
Outdated
Show resolved
Hide resolved
carsonbot
changed the title
OskarStark
reviewed
Sep 17, 2021
| @@ -96,7 +96,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| $success = $response->toArray(false); | |||
|
|
|||
| $sentMessage = new SentMessage($message, (string) $this); | |||
| $sentMessage->setMessageId($success['results'][0]['message_id']); | |||
| $sentMessage->setMessageId($success['results'][0]['message_id'] ?? ''); | |||
There was a problem hiding this comment.
Let's wrap this in an if Statement and do not call the setMessageId method
fabpot
approved these changes
Sep 19, 2021
|
Thank you @dima-gr. |
|
Now one need to check for null and empty string. I am still in favor of not calling the method to only return a string when it is a valid message id. WDYT @fabpot |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent setting null value from firebase response, previous pull request - #43040