Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Messenger] set ResetServicesListener as low priority #43577

Merged
merged 1 commit into from Oct 19, 2021
Merged

[Messenger] set ResetServicesListener as low priority #43577

merged 1 commit into from Oct 19, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 19, 2021 •
edited

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

So that regular listeners don't start with resetted services and so that the profiler can collect info about regular listeners before being reset.

@carsonbot carsonbot added this to the 5.4 milestone Oct 19, 2021
fabpot
fabpot reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description to explain why this is needed? This will help in a few years when we will wonder why we changed it back then :)

@nicolas-grekas
Copy link
Member Author

Updated.

lyrixx
lyrixx approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabpot
Copy link
Member

fabpot commented Oct 19, 2021

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1562c98 into symfony:5.4 Oct 19, 2021
@nicolas-grekas nicolas-grekas deleted the msg-reset branch October 20, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolas-grekas @fabpot @lyrixx @chalasr @carsonbot