[VarExporter] escape unicode chars involved in directionality #43909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's about Php dumpers like |
lyrixx
changed the title
|
They could be updated to use VarExporter. But from another pov, what's the point since all this is going to be autogenerated, and the "vulnerability" targets human reviews? |
nicolas-grekas
force-pushed
the
ve-lre
branch
from
b802d36
to
1a86c28
Compare
|
@jderusse for cases relying on |
stof
approved these changes
Nov 3, 2021
fabpot
approved these changes
Nov 3, 2021
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.trojansource.codes/, source code should never contain directional characters.
Let's escape them.