Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix PHP 8.1 deprecation in ChoiceQuestion #45181

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[Console] Fix PHP 8.1 deprecation in ChoiceQuestion #45181

merged 1 commit into from
Jan 26, 2022

Conversation

Rezyan
Copy link
Contributor

@Rezyan Rezyan commented Jan 25, 2022

Q A
Branch? 6.0 4.4 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45179
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for 4.4 (my bad - no worry, we can switch the branch while merging).
Thanks for doing your first PR on Symfony!

@chalasr
Copy link
Member

chalasr commented Jan 25, 2022

Can you fix fabbot's report also? (see CI checks)

@Rezyan
Copy link
Contributor Author

Rezyan commented Jan 26, 2022

Can you fix fabbot's report also? (see CI checks)

Done too. :)

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.4

@nicolas-grekas nicolas-grekas changed the title [Console] PHP 8.1 Depreciations : Passing null to parameter of type string [Console] Fix PHP 8.1 deprecation in ChoiceQuestion Jan 26, 2022
@nicolas-grekas
Copy link
Member

Thank you @brokensourcecode.

@nicolas-grekas nicolas-grekas merged commit 747e298 into symfony:4.4 Jan 26, 2022
@derrabus
Copy link
Member

Linking #41552 to keep track of PHP 8.1 fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants