[DependencyInjection] Add an env function to DI expression language #45450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
commented
Feb 16, 2022
| @@ -1586,7 +1586,7 @@ private function getExpressionLanguage(): ExpressionLanguage | |||
| if (!class_exists(\Symfony\Component\ExpressionLanguage\ExpressionLanguage::class)) { | |||
| throw new LogicException('Unable to use expressions as the Symfony ExpressionLanguage component is not installed.'); | |||
| } | |||
| $this->expressionLanguage = new ExpressionLanguage(null, $this->expressionLanguageProviders); | |||
| $this->expressionLanguage = new ExpressionLanguage(null, $this->expressionLanguageProviders, null, \Closure::fromCallable([$this, 'getEnv'])); | |||
There was a problem hiding this comment.
This is the only way I found to allow the expression language to fetch an env variable outside of a dumped container because of the getEnv visibility but maybe we could make the method public instead.
carsonbot
changed the title
|
Thank you @jvasseur. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 11, 2022
…xpression function (jvasseur) This PR was merged into the 6.1 branch. Discussion ---------- [DependencyInjection] Add documentation for the env DI expression function Doc PR for symfony/symfony#45450 Commits ------- bcbf1f3 Add documentation for the env DI expresion function
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add an
envfunction to the DI expression language provider to ease creating expressions that depends on an environment variable.