[Serializer] Fix throwing right exception in ArrayDenormalizer with invalid type #47169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
fix-array-denormalizer
branch
from
cfef3ac
to
6337bfd
Compare
nicolas-grekas
approved these changes
Aug 3, 2022
fabpot
approved these changes
Aug 3, 2022
|
Thank you @norkunas. |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
|
Fixes #46649. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible to catch most errors with serializer when using
DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS => truebut there was no tests trying to deserialize list of objects with an invalid value.So it failed my expectations, because in an api using serializer, consumers could get 500 instead of the proper response, therefore I've submit this as a bugfix.