[HttpKernel] FileProfilerStorage remove expired profiles mechanism #47352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
alamirault
force-pushed
the
feature/45831-remove-expired-profiles
branch
from
c670f8a
to
6cd2a51
Compare
alamirault
changed the title
fabpot
requested changes
Aug 22, 2022
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Aug 25, 2022
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
94noni
reviewed
Oct 28, 2022
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
alamirault
force-pushed
the
feature/45831-remove-expired-profiles
branch
from
cb75093
to
cf10b53
Compare
94noni
reviewed
Oct 29, 2022
nicolas-grekas
force-pushed
the
feature/45831-remove-expired-profiles
branch
2 times, most recently
from
da36747
to
600596f
Compare
nicolas-grekas
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
I updated the PR with the following changes:
- set expiration at 2 days
- run randomly 1 / 10
- never write to index.csv but store a seek offset in index.csv.offset
The seek offset allows looking up for files to prune very quickly, that's why 1/10 is enough IMHO.
index.csv is going to grow but this file is small and doing so saves us from race conditions.
94noni
approved these changes
Dec 16, 2022
|
Thanks Nicolas, I like your rework ! |
fabpot
approved these changes
Dec 18, 2022
|
Thank you @alamirault. |
fabpot
force-pushed
the
feature/45831-remove-expired-profiles
branch
from
162495e
to
58d0662
Compare
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jul 13, 2023
…age (radar3301) This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel] Skip corrupted CSV data in FileProfilerStorage | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Partially fixes #50942, improves/fixes on PR #50913, partially fixes #50816 | License | MIT Technically, part of this fix could go all the way back to 2.1, but since we're not sure why/how exactly the index.csv file is being corrupted in the first place, this PR should just serve as a stop-gap measure until the root cause can be identified. A corrupted index.csv file is especially noticeable since 6.3, when the "Remove Expired Profiles" feature was added by #47352 . RE: improves/fixes on PR #50913: Warnings are (usually?) only escalated to errors in debug mode, so having a try/catch is a bit more overhead than I think is actually needed, and I believe just checking that the line read from the csv is not corrupted is the better/faster option. Granted, the profiler should really only be active in debug/non-production modes anyway, but "should" and reality usually don't align... `@alamirault` `@MatTheCat` `@benjaminfunk` `@Pelagoss` `@derrabus` Commits ------- b4e942d Update FileProfilerStorage.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt for limit number of profiles saved (discussed in #45831).
When we save new profile, all expired profiles are removed. Expiration is one day for the moment.
Questions:
0, like an unexpired profile ?TODOS: