[HttpKernel] Skip corrupted CSV data in FileProfilerStorage #50947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radar3301
changed the title
|
Thank you. Please pick a more meaningful PR title and add a test. |
radar3301
changed the title
Done. No idea how I didn't see that.
Sorry, but I'm not going to write 50+ lines of code of unit test for such a trivial 2 LoC sanity check... |
radar3301
changed the title
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
Outdated
Show resolved
Hide resolved
fix "Undefined array key" by skipping invalid/corrupted lines
nicolas-grekas
force-pushed
the
6.3-file-profiler-storage
branch
from
d30f689
to
b4e942d
Compare
|
Thank you @radar3301. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, part of this fix could go all the way back to 2.1, but since we're not sure why/how exactly the index.csv file is being corrupted in the first place, this PR should just serve as a stop-gap measure until the root cause can be identified.
A corrupted index.csv file is especially noticeable since 6.3, when the "Remove Expired Profiles" feature was added by #47352 .
RE: improves/fixes on PR #50913:
Warnings are (usually?) only escalated to errors in debug mode, so having a try/catch is a bit more overhead than I think is actually needed, and I believe just checking that the line read from the csv is not corrupted is the better/faster option. Granted, the profiler should really only be active in debug/non-production modes anyway, but "should" and reality usually don't align...
@alamirault @MatTheCat @benjaminfunk @Pelagoss @derrabus