[HttpClient] Fix seeking in not-yet-initialized requests

[nicolas-grekas]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Reported on Slack by @drupol

[drupol]

Oh ! Going to test this ASAP ! Thanks @nicolas-grekas !

[drupol]

I tested it and it works, however, there is still an issue in our app.

This is because of PsrHttpFactory.php#L130. I have the feeling that it also need some adaptations.

[drupol]

I made further test, but I'm still unable to get the body of a response twice. I'm also unable to reproduce the issue in a few lines of code.

I made a screenshot after adding some dump and dd in Psr18Client::sendRequest(), without changing anything else, as such:

   /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        try {
            $body = $request->getBody();

            if ($body->isSeekable()) {
                $body->seek(0);
            }

            $response = $this->client->request($request->getMethod(), (string) $request->getUri(), [
                'headers' => $request->getHeaders(),
                'body' => $body->getContents(),
                'http_version' => '1.0' === $request->getProtocolVersion() ? '1.0' : null,
            ]);

            $psrResponse = $this->responseFactory->createResponse($response->getStatusCode());

            foreach ($response->getHeaders(false) as $name => $values) {
                foreach ($values as $value) {
                    try {
                        $psrResponse = $psrResponse->withAddedHeader($name, $value);
                    } catch (\InvalidArgumentException $e) {
                        // ignore invalid header
                    }
                }
            }

            if ($response instanceof StreamableInterface) {
                dump('Response is StreamableInterface', $response);
                $body = $response->toStream(false);
            } else {
                dump('Response is not StreamableInterface', $response);
                $body = StreamWrapper::createResource($response, $this->client);
            }

            $body = $this->streamFactory->createStreamFromResource($body);

            $r = $psrResponse->withBody($body);

            dump((string)$r->getBody());
            dd((string)$r->getBody());

            return $r;
        } catch (TransportExceptionInterface $e) {
            if ($e instanceof \InvalidArgumentException) {
                throw new Psr18RequestException($e, $request);
            }

            throw new Psr18NetworkException($e, $request);
        }
    }

And here's the result. Sorry for the pixelisation of the information, but they are not relevant here.

[nicolas-grekas]

Please provide a reproducing script if you can, I don't be able to understand without one.

[drupol]

I've spent the whole evening trying to reproduce it, without luck. I'll try again this weekend.

[drupol]

What I propose is to merge this PR, then I'll open another issue for the rest. WDYT ?