-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger] Fix amqp socket lost #47831
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
I don't understand why test is failing |
Failures are unrelated I'd say. Can you please add |
Done @nicolas-grekas Thanks for the review :) |
415b04a
to
e64b57a
Compare
Co-authored-by: Miguel Fernandez <mfernandez@nuglif.com>
e64b57a
to
bdeef74
Compare
Thank you @GurvanVgx. |
I'm taking the work done from someone else and and adding the remarks mentionned because there is no activity on this PR
PR: #47574
Network can fail in many ways, sometimes pretty subtle.
To avoid error messages "Library error: a socket error occurred", we detect when heartbeat as expired, and disconnect the chanmel connection, and force a reconnect.
Here a explanation to justify the condition :
https://www.rabbitmq.com/heartbeats.html#:~:text=Heartbeat%20frames%20are%20sent%20about,TCP%20connection%20will%20be%20closed.