Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Fix amqp socket lost #47831

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

GurvanVgx
Copy link
Contributor

@GurvanVgx GurvanVgx commented Oct 11, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #42825
License MIT
Doc PR N/A

I'm taking the work done from someone else and and adding the remarks mentionned because there is no activity on this PR

PR: #47574

Network can fail in many ways, sometimes pretty subtle.

To avoid error messages "Library error: a socket error occurred", we detect when heartbeat as expired, and disconnect the chanmel connection, and force a reconnect.

Here a explanation to justify the condition :
https://www.rabbitmq.com/heartbeats.html#:~:text=Heartbeat%20frames%20are%20sent%20about,TCP%20connection%20will%20be%20closed.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@GurvanVgx
Copy link
Contributor Author

I don't understand why test is failing

@nicolas-grekas
Copy link
Member

Failures are unrelated I'd say. Can you please add Miguel Fernandez <mfernandez@nuglif.com> as co-author?

@carsonbot carsonbot changed the title Fix amqp socket lost [Messenger] Fix amqp socket lost Oct 11, 2022
@GurvanVgx
Copy link
Contributor Author

Done @nicolas-grekas

Thanks for the review :)

@nicolas-grekas nicolas-grekas force-pushed the fix-amqp-socket-error branch 2 times, most recently from 415b04a to e64b57a Compare October 11, 2022 16:54
Co-authored-by: Miguel Fernandez <mfernandez@nuglif.com>
@fabpot
Copy link
Member

fabpot commented Oct 15, 2022

Thank you @GurvanVgx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants