[Form] FormBuilder Bug Fix: remove() was not properly removing children #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test covering this case? |
|
Sure, added a test case. It fails before the patch and passes after. |
|
Thanks. Can you please add a comment to the test with the URL of this PR? Also, please squash your commits into one when your done. |
FormBuilder initially sets unresolved children as NULL, until resolved. If FormBuilder::remove() is called before that child is resolved, the if statement turns false, because isset(null) is false, when it should be true. Instead, we should check to see if the key exists, and if so, process and unset it. Closes #4803
|
Oops, I deleted the remote branch and re-pushed without realizing we'd lose some history on this PR page. Live and learn I suppose. |
|
Thanks! |
fabpot
added a commit
that referenced
this pull request
Jul 10, 2012
Commits ------- f71e2a8 [Form] FormBuilder Bug Fix: remove() was not properly removing children Discussion ---------- [Form] FormBuilder Bug Fix: remove() was not properly removing children Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #4803 License of the code: MIT FormBuilder initially sets unresolved children as NULL, until resolved. If FormBuilder::remove() is called before that child is resolved, the if statement turns false, because isset(null) is false, when it should be true. Instead, we should check to see if the key exists, and if so, process and unset it. Closes #4803 --------------------------------------------------------------------------- by bschussek at 2012-07-10T07:41:55Z Can you please add a test covering this case? --------------------------------------------------------------------------- by ChrisTickner at 2012-07-10T09:43:07Z Sure, added a test case. It fails before the patch and passes after. --------------------------------------------------------------------------- by bschussek at 2012-07-10T09:47:06Z Thanks. Can you please add a comment to the test with the URL of this PR? Also, please squash your commits into one when your done. --------------------------------------------------------------------------- by ChrisTickner at 2012-07-10T10:02:16Z Oops, I deleted the remote branch and re-pushed without realizing we'd lose some history on this PR page. Live and learn I suppose. --------------------------------------------------------------------------- by bschussek at 2012-07-10T10:18:20Z Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4803
License of the code: MIT
FormBuilder initially sets unresolved children as NULL, until resolved.
If FormBuilder::remove() is called before that child is resolved, the
if statement turns false, because isset(null) is false, when it should
be true. Instead, we should check to see if the key exists, and if so,
process and unset it.
Closes #4803