Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] Add SimpleTextin bridge #48495

Merged
merged 1 commit into from Mar 29, 2023
Merged

[Notifier] Add SimpleTextin bridge #48495

merged 1 commit into from Mar 29, 2023

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT[
Doc PR symfony/symfony-docs#17510
Recipe symfony/recipes#1160

@carsonbot carsonbot added this to the 6.3 milestone Dec 5, 2022
OskarStark
OskarStark reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and please make fabbot happy, thanks 😃

src/Symfony/Component/Notifier/Bridge/SimpleTextin/README.md Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/Tests/SimpleTextinTransportTest.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/Tests/SimpleTextinTransportTest.php Show resolved Hide resolved
OskarStark
OskarStark approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the supports() message is adjusted

fabpot
fabpot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments

src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/LICENSE Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinOptions.php Outdated Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Mar 29, 2023

Thank you @gnito-org.

@fabpot fabpot merged commit f2ff84f into symfony:6.3 Mar 29, 2023
3 of 9 checks passed
@gnito-org gnito-org deleted the simple-textin-notifier branch May 31, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnito-org @fabpot @OskarStark @carsonbot