-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifier] Add SimpleTextin bridge #48495
Conversation
gnito-org
commented
Dec 5, 2022
Q | A |
---|---|
Branch? | 6.3 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | |
License | MIT[ |
Doc PR | symfony/symfony-docs#17510 |
Recipe | symfony/recipes#1160 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and please make fabbot happy, thanks 😃
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/Tests/SimpleTextinTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/Tests/SimpleTextinTransportTest.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the supports()
message is adjusted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/SimpleTextin/SimpleTextinOptions.php
Outdated
Show resolved
Hide resolved
135b6ee
to
f2d9af6
Compare
Thank you @gnito-org. |