Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] STDOUT blocks infinitely under Windows when STDERR is filled #49604

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

TemaYud
Copy link
Contributor

@TemaYud TemaYud commented Mar 5, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

stream_get_contents() on STDOUT blocks infinitely under Windows when STDERR is filled under some circumstances. Open STDERR in append mode ("a"), then this will work.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title STDOUT blocks infinitely under Windows when STDERR is filled [Process] STDOUT blocks infinitely under Windows when STDERR is filled Mar 9, 2023
@carsonbot carsonbot changed the title [Process] STDOUT blocks infinitely under Windows when STDERR is filled [Mailer] STDOUT blocks infinitely under Windows when STDERR is filled Mar 9, 2023
@nicolas-grekas
Copy link
Member

The failures look related, maybe this should be done only on Windows?

'\\' === \DIRECTORY_SEPARATOR ? 'a' : 'w'

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 5.4 Mar 10, 2023
@nicolas-grekas
Copy link
Member

Thank you @TemaYud.

@nicolas-grekas nicolas-grekas merged commit 626954d into symfony:5.4 Mar 10, 2023
This was referenced Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants