[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

PEtanguy · 2023-05-11T16:57:45Z

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	TODO

Hello,

This PR is aimed at updating the config for the sendinblue mailer.
As you might have seen, Sendinblue has rebranded to Brevo and also rewrote their apis.
This change ensure compatibility with the new endpoints and removes any reference to Sendinblue.

This is the notifier PR: #50296

src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md

src/Symfony/Component/Mailer/Bridge/Brevo/README.md

src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

stof · 2023-05-12T11:03:01Z

src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

+    }
+
+    /**
+     * @return array<int, string>


the return type is actually list<array{email: string, name?: string}>

stof · 2023-05-12T11:06:06Z

src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

+    /**
+     * @return array<int, string>
+     */
+    protected function stringifyAddresses(array $addresses): array


However the protected method of the AbstractTransport with a different return type is a bad idea. This should use a different method name for the needs of this class

formatAddresses() ?

this looks like a good name

@PEtanguy you haven't replaced this method

src/Symfony/Component/Mailer/Bridge/Brevo/composer.json

src/Symfony/Component/Mailer/Bridge/Sendinblue/composer.json

stof · 2023-05-16T09:18:02Z

src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

@@ -76,7 +76,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
    /**
     * @return list<array{email: string, name?: string}>
     */
-    protected function stringifyAddresses(array $addresses): array
+    protected function formatAddresses(array $addresses): array


should be a private method as it does not try to overwrite the parent method anymore.

PEtanguy · 2023-05-24T20:56:28Z

I will make the documentation once this is merged. I also noticed an error in the doc of another transport.

OskarStark · 2023-06-14T12:05:01Z

src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md

+6.3
+---
+
+* Added the bridge as a replacement of the deprecated Sendinblue one.


Suggested change

* Added the bridge as a replacement of the deprecated Sendinblue one.

* Add the bridge

@PEtanguy you forgot this change when fixing requested things

src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md

OskarStark · 2023-06-14T12:06:44Z

I would not touch the other bridge in this PR; let's just add this as a new bridge. No need to deprecate the code IMHO, we can abandon the whole package via packagist.

WDYT @fabpot ?

stof · 2023-06-14T17:36:53Z

Well, triggering a deprecation when someone configures a mailer DSN using the sendinblue schemes is needed to help them migrate.

If we only abandon the package, projects removing the old bridge without updating their env variables in prod would get a broken project due to using an unsupported scheme.
Side note: I would even wait a bit before marking the package as abandoned as FrameworkBundle 5.4 and 6.3 won't support the Brevo bridge (it does not register it as a supported factory) while the SendinblueBridge technically still works thanks to the BC layer of the API itself (where the old domain still works). We cannot mark a package as abandoned only for some versions and not for others.

PEtanguy · 2023-06-20T20:47:28Z

I agree with @stof , we can abandon Sendinblue later. I will keep the deprecations on this PR and on the one of the notifier (#50296)

…anguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] Add Brevo bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue notifier. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the mailer PR: #50302 Commits ------- 731f9b0 [Notifier] Add Brevo bridge (formerly Sendinblue)

…anguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] Add Brevo bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue notifier. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the mailer PR: symfony/symfony#50302 Commits ------- 731f9b02ef [Notifier] Add Brevo bridge (formerly Sendinblue)

fabpot · 2023-07-09T07:02:44Z

Thank you @PEtanguy.

This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Rename Sendinlue to Brevo Sendinblue mailer transport was deprecated in Symfony 6.4, new transport Brevo was created due to the service name change. https://www.brevo.com/fr/blog/pourquoi-brevo/ PR : symfony/symfony#50302 Commits ------- 10ef904 [Mailer] Rename Sendinlue to Brevo

…anguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] Add Brevo bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue notifier. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the mailer PR: symfony/symfony#50302 Commits ------- 731f9b02ef [Notifier] Add Brevo bridge (formerly Sendinblue)

xabbuh · 2023-08-15T08:55:48Z

#51295 should be enough, right?

thomas2411 · 2023-08-15T08:57:55Z

#51295 should be enough, right?

Yes, thank you :)

carsonbot added Status: Needs Review Feature labels May 11, 2023

carsonbot added this to the 6.3 milestone May 11, 2023

PEtanguy mentioned this pull request May 11, 2023

[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

Merged

PEtanguy changed the title ~~New Brevo mailer bridge (formerly Sendinblue)~~ [Mailer] New Brevo mailer bridge (formerly Sendinblue) May 11, 2023

PEtanguy force-pushed the new_mailer_bridge_brevo branch from 8cf7fda to 1e6df84 Compare May 11, 2023 17:07

stof reviewed May 12, 2023

View reviewed changes

src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md Outdated Show resolved Hide resolved

src/Symfony/Component/Mailer/Bridge/Brevo/README.md Outdated Show resolved Hide resolved

stof requested changes May 12, 2023

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels May 12, 2023

carsonbot changed the title ~~[Mailer] New Brevo mailer bridge (formerly Sendinblue)~~ New Brevo mailer bridge (formerly Sendinblue) May 12, 2023

stof reviewed May 16, 2023

View reviewed changes

nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023

PEtanguy force-pushed the new_mailer_bridge_brevo branch 2 times, most recently from a3a2944 to 72a6287 Compare May 24, 2023 20:45

94noni mentioned this pull request Jun 1, 2023

[Mailer] Deprecate Sendinblue Transport, Create Brevo Transport #50518

Closed

This was referenced Jun 1, 2023

Add symfony/brevo-mailer recipe symfony/recipes#1207

Merged

[Mailer] Rename Sendinlue to Brevo symfony/symfony-docs#18359

Merged

PEtanguy force-pushed the new_mailer_bridge_brevo branch from 73582e0 to 59e14a0 Compare June 8, 2023 17:22

OskarStark changed the title ~~New Brevo mailer bridge (formerly Sendinblue)~~ [Mailer] New Brevo mailer bridge (formerly Sendinblue) Jun 14, 2023

OskarStark added the Mailer label Jun 14, 2023

OskarStark reviewed Jun 14, 2023

View reviewed changes

src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md Outdated Show resolved Hide resolved

stof approved these changes Jun 21, 2023

View reviewed changes

carsonbot removed the Status: Needs Work label Jun 21, 2023

carsonbot added the Status: Reviewed label Jun 21, 2023

[Mailer] New Brevo mailer bridge (formerly Sendinblue)

f537358

fabpot force-pushed the new_mailer_bridge_brevo branch from 66fa84c to f537358 Compare July 9, 2023 07:02

fabpot merged commit 710e16c into symfony:6.4 Jul 9, 2023
6 of 9 checks passed

fabpot mentioned this pull request Jul 9, 2023

[Mailer] New Brevo mailer bridge (formerly Sendinblue) symfony/symfony-docs#18541

Closed

This was referenced Oct 21, 2023

Release v6.4.0-BETA1 #52220

Merged

Release v7.0.0-BETA1 #52224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

PEtanguy commented May 11, 2023 •

edited by OskarStark

stof May 12, 2023

stof May 12, 2023

PEtanguy May 12, 2023

stof May 12, 2023

stof May 15, 2023

stof May 16, 2023

PEtanguy May 24, 2023

PEtanguy commented May 24, 2023 •

edited

OskarStark Jun 14, 2023

stof Jun 21, 2023

OskarStark commented Jun 14, 2023 •

edited

stof commented Jun 14, 2023

PEtanguy commented Jun 20, 2023

fabpot commented Jul 9, 2023

xabbuh commented Aug 15, 2023

thomas2411 commented Aug 15, 2023

	* Added the bridge as a replacement of the deprecated Sendinblue one.
	* Add the bridge

[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

Conversation

PEtanguy commented May 11, 2023 • edited by OskarStark

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PEtanguy commented May 24, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OskarStark commented Jun 14, 2023 • edited

stof commented Jun 14, 2023

PEtanguy commented Jun 20, 2023

fabpot commented Jul 9, 2023

xabbuh commented Aug 15, 2023

thomas2411 commented Aug 15, 2023

PEtanguy commented May 11, 2023 •

edited by OskarStark

PEtanguy commented May 24, 2023 •

edited

OskarStark commented Jun 14, 2023 •

edited