[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

PEtanguy · 2023-05-10T17:07:43Z

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	TODO

Hello,

This PR is aimed at updating the config for the sendinblue notifier.
As you might have seen, Sendinblue has rebranded to Brevo and also rewrote their apis.
This change ensure compatibility with the new endpoints and removes any reference to Sendinblue.

This is the mailer PR: #50302

carsonbot · 2023-05-10T17:07:45Z

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

src/Symfony/Component/Notifier/Bridge/Brevo/composer.json

stof · 2023-05-11T08:33:48Z

@PEtanguy are you also working on the mailer bridge ?

PEtanguy · 2023-05-11T09:55:40Z

@stof yes i am waiting to merge this PR to open the Mailer one.
Do yo know how I can skip the failing tests by any chance?

The tests are failing because of the deprecation trigger

stof · 2023-05-11T13:57:06Z

You need to mark tests as @group legacy when they test deprecated classes.

And maybe the deprecation need to be triggered only if the factory is actually used instead of triggering it as soon as it is autoloaded, in case FrameworkBundle registers all installed factories.

94noni · 2023-05-11T16:19:42Z

src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md

+6.3
+---
+
+* Added the bridge


should you mentioned that this is the replacement of https://packagist.org/packages/symfony/sendinblue-notifier?
and also in the other composer, mark it as deprecated?

Absolutely!

OskarStark · 2023-05-24T21:20:17Z

src/Symfony/Component/Notifier/Bridge/Brevo/BrevoTransport.php

+    private string $apiKey;
+    private string $sender;
+
+    public function __construct(#[\SensitiveParameter] string $apiKey, string $sender, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null)


We can use constructor property promotion for apiKey and sender

src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md

OskarStark · 2023-06-14T12:02:37Z

src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md

+6.4
+---
+
+* Added the bridge


Suggested change

* Added the bridge

* Add the bridge

We can add an info about a replacement in the README; no need for it in the changeling file. From a code POV this is simply a new bridge

OskarStark · 2023-06-14T12:03:10Z

src/Symfony/Component/Notifier/Bridge/Brevo/README.md

@@ -0,0 +1,25 @@
+Brevo Notifier
+===================


Suggested change

===================

==============

OskarStark · 2023-06-14T12:04:12Z

src/Symfony/Component/Notifier/Bridge/Brevo/README.md

@@ -0,0 +1,25 @@
+Brevo Notifier
+===================
+


A note about the renaming can be put here

OskarStark · 2023-06-14T12:07:23Z

src/Symfony/Component/Notifier/Bridge/Brevo/composer.json

+{
+    "name": "symfony/brevo-notifier",
+    "type": "symfony-notifier-bridge",
+    "description": "Symfony Brevo Notifier Bridge - formerly Sendinblue",


Suggested change

"description": "Symfony Brevo Notifier Bridge - formerly Sendinblue",

"description": "Symfony Brevo Notifier Bridge",

OskarStark · 2023-06-14T12:07:35Z

src/Symfony/Component/Notifier/Bridge/Brevo/composer.json

+    "require": {
+        "php": ">=8.1",
+        "symfony/http-client": "^5.4|^6.0",
+        "symfony/notifier": "^6.3"


Suggested change

"symfony/notifier": "^6.3"

"symfony/notifier": "^6.4"

OskarStark

LGTM after my comments and the revert of src/Symfony/Component/Notifier/Bridge/Sendinblue/*

fabpot · 2023-07-09T07:00:14Z

Thank you @PEtanguy.

… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: #50296 Commits ------- f537358 [Mailer] New Brevo mailer bridge (formerly Sendinblue)

… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: symfony/symfony#50296 Commits ------- f537358e5a [Mailer] New Brevo mailer bridge (formerly Sendinblue)

PEtanguy mentioned this pull request May 10, 2023

[Mailer] [Sendinblue] refacto sendinblue to brevo #50279

Closed

PEtanguy marked this pull request as ready for review May 10, 2023 17:10

PEtanguy requested a review from OskarStark as a code owner May 10, 2023 17:10

carsonbot added the Status: Needs Review label May 10, 2023

carsonbot added this to the 6.3 milestone May 10, 2023

stof reviewed May 10, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Brevo/composer.json Outdated Show resolved Hide resolved

PEtanguy force-pushed the new_notifier_bridge_brevo branch 2 times, most recently from 9a467e7 to 9622d22 Compare May 10, 2023 17:33

OskarStark changed the title ~~New notifier bridge brevo~~ [Notifier] Add brevo bridge (formerly Sendinblue) May 10, 2023

OskarStark changed the title ~~[Notifier] Add brevo bridge (formerly Sendinblue)~~ [Notifier] Add Brevo bridge (formerly Sendinblue) May 10, 2023

OskarStark added the Notifier label May 10, 2023

94noni reviewed May 11, 2023

View reviewed changes

PEtanguy force-pushed the new_notifier_bridge_brevo branch 2 times, most recently from 3adf0d1 to ae9867b Compare May 11, 2023 16:54

PEtanguy mentioned this pull request May 11, 2023

[Mailer] New Brevo mailer bridge (formerly Sendinblue) #50302

Merged

nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023

PEtanguy force-pushed the new_notifier_bridge_brevo branch 2 times, most recently from c90b1cf to b4dcd18 Compare May 24, 2023 20:55

OskarStark reviewed May 24, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md Outdated Show resolved Hide resolved

OskarStark reviewed May 24, 2023

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md Outdated Show resolved Hide resolved

PEtanguy force-pushed the new_notifier_bridge_brevo branch 3 times, most recently from f079a58 to 6746d3c Compare May 24, 2023 21:47

PEtanguy force-pushed the new_notifier_bridge_brevo branch from 6746d3c to 6cb3054 Compare June 8, 2023 17:15

OskarStark reviewed Jun 14, 2023

View reviewed changes

OskarStark requested changes Jun 14, 2023

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jun 14, 2023

fabpot approved these changes Jul 9, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jul 9, 2023

[Notifier] Add Brevo bridge (formerly Sendinblue)

731f9b0

fabpot force-pushed the new_notifier_bridge_brevo branch from 3053f74 to 731f9b0 Compare July 9, 2023 07:00

fabpot mentioned this pull request Jul 9, 2023

[Notifier] Add Brevo bridge (formerly Sendinblue) symfony/symfony-docs#18540

Closed

fabpot merged commit ce9bbd3 into symfony:6.4 Jul 9, 2023
5 of 9 checks passed

This was referenced Oct 21, 2023

Release v6.4.0-BETA1 #52220

Merged

Release v7.0.0-BETA1 #52224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

PEtanguy commented May 10, 2023 •

edited by OskarStark

carsonbot commented May 10, 2023

stof commented May 11, 2023

PEtanguy commented May 11, 2023

stof commented May 11, 2023

94noni May 11, 2023

PEtanguy May 11, 2023

OskarStark May 24, 2023

OskarStark Jun 14, 2023

OskarStark Jun 14, 2023

OskarStark Jun 14, 2023

OskarStark Jun 14, 2023

OskarStark Jun 14, 2023

OskarStark left a comment

fabpot commented Jul 9, 2023

	"description": "Symfony Brevo Notifier Bridge - formerly Sendinblue",
	"description": "Symfony Brevo Notifier Bridge",

[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

[Notifier] Add Brevo bridge (formerly Sendinblue) #50296

Conversation

PEtanguy commented May 10, 2023 • edited by OskarStark

carsonbot commented May 10, 2023

stof commented May 11, 2023

PEtanguy commented May 11, 2023

stof commented May 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OskarStark left a comment

Choose a reason for hiding this comment

fabpot commented Jul 9, 2023

PEtanguy commented May 10, 2023 •

edited by OskarStark