Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Deprecate annotations in favor of attributes #50983

Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 14, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Follows #50888
License MIT
Doc PR symfony/symfony-docs#18589

This PR deprecates using Doctrine annotations to configure serialization. Attributes shall be used instead.

Existing applications can be migrated easily using Rector.

Deprecation errors triggered by the bundles' functional tests will be resolved once #50888 is merged.

@derrabus derrabus force-pushed the deprecate/serializer-annotations branch from 4c78f50 to 9b7b397 Compare July 22, 2023 23:40
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit f6c7a74 into symfony:6.4 Jul 24, 2023
8 of 9 checks passed
@derrabus derrabus deleted the deprecate/serializer-annotations branch July 24, 2023 06:36
nicolas-grekas added a commit that referenced this pull request Jul 24, 2023
…abus)

This PR was merged into the 7.0 branch.

Discussion
----------

[Serializer] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #50983
| License       | MIT
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

67013e2 [Serializer] Remove Doctrine annotations support
nicolas-grekas added a commit that referenced this pull request Jul 27, 2023
…derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Serializer] Fix tests for extended Context attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Follows #50983
| License       | MIT
| Doc PR        | not needed

In #50983, I broke one test scenario where we test that extending the `Context` class works. This PR corrects that mistake.

Commits
-------

2a6e93e [Serializer] Fix tests for extended Context attributes
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants