Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] Fix tests for extended Context attributes #51126

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[Serializer] Fix tests for extended Context attributes #51126

merged 1 commit into from
Jul 27, 2023

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Follows #50983
License MIT
Doc PR not needed

In #50983, I broke one test scenario where we test that extending the Context class works. This PR corrects that mistake.

@derrabus derrabus requested a review from dunglas as a code owner July 27, 2023 07:54
@carsonbot carsonbot added this to the 6.4 milestone Jul 27, 2023
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit deb160a into symfony:6.4 Jul 27, 2023
7 of 9 checks passed
@derrabus derrabus deleted the bugfix/dummy-context-child branch July 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derrabus @nicolas-grekas @carsonbot