[CI] Make tests green again #51622
Merged
[CI] Make tests green again #51622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vtsykun
commented
Sep 11, 2023
•
vtsykun
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
vtsykun
force-pushed
the
fix/tests-green
branch
from
1cfd7f9
to
32c9af1
Compare
vtsykun
force-pushed
the
fix/tests-green
branch
2 times, most recently
from
f3bf778
to
b7114c7
Compare
Nyholm
requested changes
Sep 11, 2023
| @@ -456,6 +456,11 @@ public function bitcount($key, $start = 0, $end = -1, $by_bit = false): \Relay\R | |||
| return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitcount(...\func_get_args()); | |||
| } | |||
|
|
|||
| public function bitfield($key, ...$args): \Relay\Relay|array|false | |||
There was a problem hiding this comment.
The test Symfony\Component\Cache\Tests\Traits\RedisProxiesTest::testRelayProxy failed after update php extension ext-relay, just I sync proxy trait with latest changes of Relay\Relay class
vtsykun
commented
Sep 11, 2023
vtsykun
force-pushed
the
fix/tests-green
branch
from
b7114c7
to
2024172
Compare
derrabus
reviewed
Sep 11, 2023
src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/DoctrineIntegrationTest.php
Outdated
Show resolved
Hide resolved
vtsykun
force-pushed
the
fix/tests-green
branch
from
2024172
to
a642491
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 11, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [Security] Fix security tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Follows #51622 | License | MIT | Doc PR | - Related to issue #51104, after it security bundle at least requires `symfony/security-http:6.3.4` to keep the tests is green Commits ------- 26cff6c Fix security tests
vtsykun
force-pushed
the
fix/tests-green
branch
from
a642491
to
7cad70d
Compare
|
Looks like the random bug #51105 is back again. |
nicolas-grekas
approved these changes
Sep 12, 2023
|
Thank you @vtsykun. |
|
(I cherry-picked the changes that applied to 5.4 and 6.3 respectively) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.