Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make tests green again #51622

Merged
merged 1 commit into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Symfony/Component/Cache/Traits/RelayProxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,11 @@
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitcount(...\func_get_args());
}

public function bitfield($key, ...$args): \Relay\Relay|array|false

Check failure on line 459 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedMethod

src/Symfony/Component/Cache/Traits/RelayProxy.php:459:21: PossiblyUnusedMethod: Cannot find any calls to method Symfony\Component\Cache\Traits\RelayProxy::bitfield (see https://psalm.dev/087)

Check failure on line 459 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedMethod

src/Symfony/Component/Cache/Traits/RelayProxy.php:459:21: PossiblyUnusedMethod: Cannot find any calls to method Symfony\Component\Cache\Traits\RelayProxy::bitfield (see https://psalm.dev/087)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. why was this method added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test Symfony\Component\Cache\Tests\Traits\RedisProxiesTest::testRelayProxy failed after update php extension ext-relay, just I sync proxy trait with latest changes of Relay\Relay class

{
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->bitfield(...\func_get_args());
}

public function config($operation, $key = null, $value = null): \Relay\Relay|array|bool
{
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->config(...\func_get_args());
Expand Down Expand Up @@ -1201,7 +1206,7 @@
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->zrevrank(...\func_get_args());
}

public function zrem($key, ...$args): \Relay\Relay|false|int

Check failure on line 1209 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedParam

src/Symfony/Component/Cache/Traits/RelayProxy.php:1209:35: PossiblyUnusedParam: Param #2 is never referenced in this method (see https://psalm.dev/134)

Check failure on line 1209 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedParam

src/Symfony/Component/Cache/Traits/RelayProxy.php:1209:35: PossiblyUnusedParam: Param #2 is never referenced in this method (see https://psalm.dev/134)
{
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->zrem(...\func_get_args());
}
Expand Down Expand Up @@ -1291,7 +1296,7 @@
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->zpopmin(...\func_get_args());
}

public function zpopmax($key, $count = 1): \Relay\Relay|array|false

Check failure on line 1299 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedParam

src/Symfony/Component/Cache/Traits/RelayProxy.php:1299:29: PossiblyUnusedParam: Param #1 is never referenced in this method (see https://psalm.dev/134)

Check failure on line 1299 in src/Symfony/Component/Cache/Traits/RelayProxy.php

View workflow job for this annotation

GitHub Actions / Psalm

PossiblyUnusedParam

src/Symfony/Component/Cache/Traits/RelayProxy.php:1299:29: PossiblyUnusedParam: Param #1 is never referenced in this method (see https://psalm.dev/134)
{
return ($this->lazyObjectState->realInstance ??= ($this->lazyObjectState->initializer)())->zpopmax(...\func_get_args());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

/**
* @author WoutervanderLoop.nl <info@woutervanderloop.nl>
*
* @requires extension openssl
*/
class SendgridSignedRequestParserTest extends AbstractRequestParserTestCase
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

/**
* @author WoutervanderLoop.nl <info@woutervanderloop.nl>
*
* @requires extension openssl
*/
class SendgridWrongSecretRequestParserTest extends AbstractRequestParserTestCase
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

/**
* @author WoutervanderLoop.nl <info@woutervanderloop.nl>
*
* @requires extension openssl
*/
class SendgridWrongSignatureRequestParserTest extends AbstractRequestParserTestCase
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function testRunFailedProcess()
(new RunProcessMessageHandler())(new RunProcessMessage(['invalid']));
} catch (RunProcessFailedException $e) {
$this->assertSame(['invalid'], $e->context->command);
$this->assertSame(127, $e->context->exitCode);
$this->assertSame('\\' === \DIRECTORY_SEPARATOR ? 1 : 127, $e->context->exitCode);

return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ public function testDumpArrayWithColor($value, $flags, $expectedOut)

public function testCollapse()
{
if ('\\' === \DIRECTORY_SEPARATOR) {
$this->markTestSkipped('This test cannot be run on Windows.');
}

$stub = new Stub();
$stub->type = Stub::TYPE_OBJECT;
$stub->class = 'stdClass';
Expand Down