[FrameworkBundle] fix broken command registration #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole/Application.php Issue must be related to commit 7a5f614 (merged 2.0), specifically this file src/Symfony/Bundle/FrameworkBundle/Console/Application.php, lines 86-88. Presumably to do "instanceof Bundle" correct class has to be imported at the top of the file: instead of use Symfony\Component\HttpKernel\Bundle; this should be use Symfony\Component\HttpKernel\Bundle\Bundle; Conflicts: src/Symfony/Bundle/FrameworkBundle/Console/Application.php
|
Duplicate of #5166 |
|
@xeross that PR was opened on master instead of 2.0 |
|
@Burgov Ah sorry, I got confused and thought this was another dupe |
fabpot
added a commit
that referenced
this pull request
Aug 3, 2012
Commits ------- 55a0b34 Fixes incorrect class used in src/Symfony/Bundle/FrameworkBundle/Console/Application.php 79c547f [FrameworkBundle] added test for fix broken command registration Discussion ---------- [FrameworkBundle] fix broken command registration fixed #5168, #5166 --------------------------------------------------------------------------- by travisbot at 2012-08-03T11:35:29Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2027699) (merged 39e964b8 into fee3f4e). --------------------------------------------------------------------------- by travisbot at 2012-08-03T11:45:14Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2027761) (merged 55a0b34 into fee3f4e). --------------------------------------------------------------------------- by xeross at 2012-08-03T11:45:45Z Duplicate of #5166 --------------------------------------------------------------------------- by Burgov at 2012-08-03T11:47:54Z @xeross that PR was opened on master instead of 2.0 --------------------------------------------------------------------------- by xeross at 2012-08-03T11:48:49Z @Burgov Ah sorry, I got confused and thought this was another dupe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #5168, #5166