[Cache][Doctrine][DoctrineBridge][Lock][Messenger] Compatibility with ORM 3 and DBAL 4 #51947
Conversation
derrabus
changed the title
carsonbot
changed the title
carsonbot
changed the title
carsonbot
changed the title
derrabus
force-pushed
the
bump/orm-3
branch
2 times, most recently
from
b543f97
to
ec0f818
Compare
| 'SELECT a.* FROM (SELECT m.id AS "id", m.body AS "body", m.headers AS "headers", m.queue_name AS "queue_name", m.created_at AS "created_at", m.available_at AS "available_at", m.delivered_at AS "delivered_at" FROM messenger_messages m WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?)) a WHERE ROWNUM <= 50', | ||
| ]; | ||
| if (!class_exists(MySQL57Platform::class)) { | ||
| // DBAL >= 4 |
There was a problem hiding this comment.
Can't we detect the Oracle changes based on something related to OraclePlatform rather than checking for the removal of MySQL57Platform ?
There was a problem hiding this comment.
If you have an idea, please let me know. 🙂
| @@ -391,7 +393,7 @@ public function testGeneratedSql(AbstractPlatform $platform, string $expectedSql | |||
| public static function providePlatformSql(): iterable | |||
| { | |||
| yield 'MySQL' => [ | |||
There was a problem hiding this comment.
DBAL 4+ separates MariaDBPlatform from MySQLPlatform. So we should add a test for it in the data provider to avoid loosing support for MariaDB.
There was a problem hiding this comment.
That test is already there, scroll down a little.
|
I'm wondering whether it make sense to do that work in the 5.4 branch while 6.4 is likely to be the active LTS by the time of the Doctrine major releases. |
derrabus
force-pushed
the
bump/orm-3
branch
2 times, most recently
from
11c0e64
to
f5266ab
Compare
We will maintain ORM 2 for quite a while, so only making Symfony 6 compatible with ORM 3 would be fine. A big problem is though, that no Symfony 5 package (except VarExporter) is actively conflicting with ORM 3. It's a dev dependency everywhere. So basically, people will be able to install ORM 3 with Symfony 5 and flood our tracker with bug reports. 😢 |
carsonbot
changed the title
|
We could explicitly conflict with ORM 3 to avoid such situation |
derrabus
changed the title
We could've done that two years ago, yes. If we do that now, Composer will just pin an old Doctrine Bridge and move on. |
|
Thank you @derrabus. |
This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Fix DBAL 4 compatibility | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT This PR backports DBAL 4 compatibility changes from #51997 that were not in #51947. Sorry for messing this up. Commits ------- 50c0fbc Fix DBAL 4 compatibility
This PR makes the 5.4 branch compatible with ORM 3 and DBAL 4.
Note: On the 5.4 branch, I cannot add ORM 3 to the root composer.json because ORM 3 requires VarExporter 6. So, only high-deps tests it is. 🤷🏻♂️