[DoctrineBridge] Fix DBAL 4 compatibility #52035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
derrabus
force-pushed
the
bugfix/dbal-4
branch
from
990a91c
to
a5638d1
Compare
carsonbot
changed the title
derrabus
force-pushed
the
bugfix/dbal-4
branch
from
a5638d1
to
838c1fa
Compare
src/Symfony/Bridge/Doctrine/Messenger/DoctrinePingConnectionMiddleware.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
bugfix/dbal-4
branch
3 times, most recently
from
e6e497e
to
b7b549e
Compare
stof
reviewed
Oct 13, 2023
src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/Fixtures/DoctrineFooType.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
bugfix/dbal-4
branch
from
b7b549e
to
50c0fbc
Compare
|
I've addressed your remarks, @stof. |
|
Thank you @derrabus. |
Merged
Merged
|
@fabpot this issue seems to suggest DBAL 4 is supported as of late October 2023, but a commit you made in February 2024 on Am I missing something? |
|
See the PR attached to the commit you linked: symfony/orm-pack#43 |
|
symfony/doctrine-bridge is compatible. |
|
Thanks for the clarifications, I will avoid it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports DBAL 4 compatibility changes from #51997 that were not in #51947. Sorry for messing this up.