[Console] InputArgument and InputOption code cleanup
#52054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
force-pushed
the
console-input-code-cleanup
branch
from
a98dccc
to
badee0e
Compare
GromNaN
reviewed
Oct 14, 2023
There was a problem hiding this comment.
- We can use
int-mask-of<InputArgument::*>for the constructor$modeparam. - The comment for
InputArgument::completeshould be improved to explain that it's called when the command resolves input completion for this argument, same forInputOption.
OskarStark
changed the title
InputArgument and InputOption code cleanup
GromNaN
approved these changes
Oct 17, 2023
OskarStark
force-pushed
the
console-input-code-cleanup
branch
3 times, most recently
from
522f6d4
to
3c3c983
Compare
|
rebased, squashed, cs fixed ✅ |
OskarStark
approved these changes
Dec 29, 2023
fabpot
approved these changes
Feb 3, 2024
fabpot
force-pushed
the
console-input-code-cleanup
branch
from
3c3c983
to
fdf207c
Compare
|
Thank you @jnoordsij. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
InputOptionandInputArgumentclasses to be slightly more consistent. Moreover it adds some additional dockblocks that were not present yet.