Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer][Notifier] Update Sendinblue / Brevo API host #52268

Merged

Conversation

vicla31
Copy link

@vicla31 vicla31 commented Oct 24, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52264
License MIT

Sendinblue rebrands to Brevo, and it simultaneously upgrade smtp and API servers.
There are 2 distincts API currently : api.sendinblue.com (deprecated but still running) and api.brevo.com (the one to use)
Unlike SMTP host, API host is not changed on LTS 5.4 and are still set to api.sendinblue.com.

@carsonbot carsonbot added this to the 5.4 milestone Oct 24, 2023
@carsonbot carsonbot changed the title [Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host [Mailer][Notifier] #52264 Update Sendinblue / Brevo API host Oct 24, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title [Mailer][Notifier] #52264 Update Sendinblue / Brevo API host [Mailer][Notifier] Update Sendinblue / Brevo API host Oct 24, 2023
@nicolas-grekas
Copy link
Member

Thank you @vicla31.

@nicolas-grekas nicolas-grekas merged commit a289293 into symfony:5.4 Oct 24, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants