Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sendinblue.com API to brevo.com in Mailer and Notifier on LTS #52264

Closed
vicla31 opened this issue Oct 24, 2023 · 2 comments
Closed

Update sendinblue.com API to brevo.com in Mailer and Notifier on LTS #52264

vicla31 opened this issue Oct 24, 2023 · 2 comments

Comments

@vicla31
Copy link

vicla31 commented Oct 24, 2023

Symfony version(s) affected

5.4

Description

Sendinblue rebrands to Brevo, and it simultaneously upgrade smtp and API servers.
There are 2 distincts API currently : api.sendinblue.com (deprecated but still running) and api.brevo.com (the one to use)
Sendinblue Mailer and Notifier are removed on 7.0 according to this issue #52097
However API host are not changed on LTS 5.4 and 6.4 and are still set to api.sendinblue.com. I suggest to update them like that was done for smtp.brevo.com

How to reproduce

Remplace api.sendinblue.com by api.brevo.com in Symfony\Component\Notifier\Bridge\Sendinblue\SendinblueTransport and Symfony\Component\Mailer\Bridge\Sendinblue\Transport\SendinblueApiTransport

Possible Solution

No response

Additional Context

No response

@xabbuh
Copy link
Member

xabbuh commented Oct 24, 2023

We did update the SMTP host (see #51119 and #51295). If the API transports require a similar change, we should do that too. PR welcome I guess.

@stof
Copy link
Member

stof commented Oct 24, 2023

Note that in 6.4, you should migrate to the Brevo bridges.

vicla31 pushed a commit to vicla31/symfony that referenced this issue Oct 24, 2023
vicla31 pushed a commit to vicla31/symfony that referenced this issue Oct 24, 2023
nicolas-grekas added a commit that referenced this issue Oct 24, 2023
…phanie)

This PR was merged into the 5.4 branch.

Discussion
----------

[Mailer][Notifier] Update Sendinblue / Brevo API host

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #52264
| License       | MIT

Sendinblue rebrands to Brevo, and it simultaneously upgrade smtp and API servers.
There are 2 distincts API currently : api.sendinblue.com (deprecated but still running) and api.brevo.com (the one to use)
Unlike SMTP host, API host is not changed on LTS 5.4 and are still set to api.sendinblue.com.

Commits
-------

554e9cc [Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host
xabbuh added a commit that referenced this issue Oct 25, 2023
* 5.4:
  fix tests on AppVeyor
  Hungarian typo fix in validators translation
  [Validator] updated Latvian translation
  [Validator] Added missing Swedish translations
  [Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host
  [Validator] Added missing Estonian translations #51939
  fix File constraint tests on 32bit PHP
  [Form] Skip merging params & files if there are no files in the first place
  [Translation] Ignore bridges in `.gitattributes` file
  Add missing Hungarian validator translations
  Added missing Bosnian translations #51929
  Added missing Serbian (sr_Latn) translations
  Added missing Serbian (sr_Cyrl) translations
  Hide generated files in GitHub diffs and statistics
  #51937 - Added missing Danish translations
xabbuh added a commit that referenced this issue Oct 25, 2023
* 6.3:
  fix tests on AppVeyor
  Hungarian typo fix in validators translation
  [Validator] updated Latvian translation
  [Validator] Added missing Swedish translations
  [Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host
  [Validator] Added missing Estonian translations #51939
  fix File constraint tests on 32bit PHP
  [Form] Skip merging params & files if there are no files in the first place
  [Translation] Ignore bridges in `.gitattributes` file
  Add missing Hungarian validator translations
  Added missing Bosnian translations #51929
  Added missing Serbian (sr_Latn) translations
  Added missing Serbian (sr_Cyrl) translations
  Bump Symfony version to 6.3.7
  Update VERSION for 6.3.6
  Update CHANGELOG for 6.3.6
  Hide generated files in GitHub diffs and statistics
  #51937 - Added missing Danish translations
xabbuh added a commit that referenced this issue Oct 25, 2023
* 6.4: (31 commits)
  [Messenger] Add call to `gc_collect_cycles()` after each message is handled
  fix tests
  fix tests on AppVeyor
  Hungarian typo fix in validators translation
  [VarDump] Fix order of dumped properties - parent goes first
  DX: drop unused import
  [Validator] updated Latvian translation
  re-introduce conflict rule with WebProfilerBundle < 6.4
  [Validator] Added missing Swedish translations
  [Mailer] [Notifier] #52264 Update Sendinblue / Brevo API host
  [Validator] Added missing Estonian translations #51939
  fix File constraint tests on 32bit PHP
  [Form] Skip merging params & files if there are no files in the first place
  [Translation] Ignore bridges in `.gitattributes` file
  [AssetMapper] Adding import-parsing case where import contains a path
  Add missing Hungarian validator translations
  Added missing Bosnian translations #51929
  add return type hints to EntityFactory
  Update UndefinedCallableHandler with "importmap", "form" and "worflow" filters/functions
  [FrameworkBundle] Fix CommandDataCollector is always registered
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants