Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle][Scheduler] Add test for autoconfigured schedule #52313

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[FrameworkBundle][Scheduler] Add test for autoconfigured schedule #52313

merged 1 commit into from
Nov 3, 2023

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Oct 26, 2023 •
edited
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

Add functional tests for autoconfigured schedules / tasks, as discussed in #51525 (comment).

@carsonbot carsonbot added this to the 6.4 milestone Oct 26, 2023
@carsonbot carsonbot changed the title [Scheduler][FrameworkBundle] Add test for autoconfigured schedule [FrameworkBundle][Scheduler] Add test for autoconfigured schedule Oct 26, 2023
@valtzu valtzu force-pushed the tests-for-autoconfigured-scheduler branch 2 times, most recently from 0853b69 to fcefd49 Compare October 26, 2023 19:10
@valtzu
Copy link
Contributor Author

valtzu commented Oct 26, 2023

Added autoconfigured scheduler tests as discussed in #51525 (comment), but those are failing in the pipeline due to missing cron dev-dependency. Should I just remove cron attributes from DummyTask or how to proceed here @fabpot ?

Locally with dragonmantank/cron-expression installed the tests pass just fine.

@fabpot
Copy link
Member

fabpot commented Oct 26, 2023

Added autoconfigured scheduler tests as discussed in #51525 (comment), but those are failing in the pipeline due to missing cron dev-dependency. Should I just remove cron attributes from DummyTask or how to proceed here @fabpot ?

Locally with dragonmantank/cron-expression installed the tests pass just fine.

You can add dragonmantank/cron-expression as a dev dependency for the bundle and in the main composer.json file.

@valtzu valtzu force-pushed the tests-for-autoconfigured-scheduler branch from fcefd49 to 3cb813a Compare October 26, 2023 19:30
@valtzu valtzu force-pushed the tests-for-autoconfigured-scheduler branch from 3cb813a to 8dd9a89 Compare October 26, 2023 19:43
@valtzu valtzu force-pushed the tests-for-autoconfigured-scheduler branch from 8dd9a89 to ea2a8cd Compare October 30, 2023 17:20
OskarStark
OskarStark approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are 💚 so I think this can be merged @nicolas-grekas @fabpot

@fabpot
Copy link
Member

fabpot commented Nov 3, 2023

Thank you @valtzu.

@fabpot fabpot merged commit ed105f1 into symfony:6.4 Nov 3, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Scheduler Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valtzu @fabpot @OskarStark @carsonbot