[Yaml] Inline::parse(null) not allowed
#52334
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Inline::parse(null) not allowedInline::parse(null) not allowed
GromNaN
force-pushed
the
yaml-parse-null
branch
from
8963eec
to
834e0ab
Compare
derrabus
approved these changes
Oct 27, 2023
|
For 5.4? |
Even if the class is internal, people may have used it directly. I don't want to break things in a bugfix version. This is not a bug fix. This is only a better error handling for PHP 8.3+ |
|
Fine for me, but then we should additionally merge #52332 into 5.4, right? |
fabpot
approved these changes
Oct 28, 2023
|
Thank you @GromNaN. |
|
Revert done in eaff34a |
xabbuh
added a commit
that referenced
this pull request
Oct 29, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [Yaml] Remove test on `Inline::parse(null)` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52334 | License | MIT This test was added by #52332 It becomes wrong with #52334 It was not reverted by eaff34a Commits ------- 9b10106 Fix wrong yaml parse null test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only called with string values in the Yaml component.
This class is internal. It allows to change the arg type.
The arg type was documented as
string.7b1715b#diff-1d97fcfb29e99f0200c3952e9a1a11c4b9f825c0f5ad4d4515b9b1805f8c988eR47