Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] Remove test on Inline::parse(null) #52353

Merged
merged 1 commit into from
Oct 29, 2023
Merged

[Yaml] Remove test on Inline::parse(null) #52353

merged 1 commit into from
Oct 29, 2023
+0 −1

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 29, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52334
License MIT

This test was added by #52332
It becomes wrong with #52334
It was not reverted by eaff34a

@GromNaN
Fix wrong yaml parse null test
9b10106 
Incomplete revert in eaff34a following b2e372d and bb5d49c
@GromNaN GromNaN requested a review from xabbuh as a code owner October 29, 2023 09:55
@carsonbot carsonbot added this to the 6.4 milestone Oct 29, 2023
@GromNaN GromNaN mentioned this pull request Oct 29, 2023
Merged
@xabbuh
Copy link
Member

xabbuh commented Oct 29, 2023

Good catch, thanks @GromNaN.

@xabbuh xabbuh merged commit fc41bf5 into symfony:6.4 Oct 29, 2023
4 of 9 checks passed
@GromNaN GromNaN deleted the fix-yaml-null branch October 29, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GromNaN @xabbuh @carsonbot