Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Allow to add bundles translations path in commands #52456

Open
wants to merge 3 commits into
base: 7.2
Choose a base branch
from

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Nov 5, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues related to #52454
License MIT

Hello !
This feature allow to get bundles translations while launching translation:extract or translation:push command.

It's helpful for application like Sylius to be able to send ALL translations to a translation provider.

Screencast_05_11_2023_13.33.25.webm

To enable this, add the following configuration under framework.translator:

# config/packages/translation.yaml
framework:
    translator:
        # ...
        include_bundles_translations_in_commands: true
        # Or if needed to exclude some bundles
        include_bundles_translations_in_commands: 
            excluded_bundles:
                - PayumBundle
                - SonataBlockBundle
                - BabDevPagerfantaBundle

Not really convinced by the config naming, if you have a better, let me know.


TODO:

  • Rebase to 7.1 once branch will be ready
  • Fill the changelog

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.0" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@Jibbarth Jibbarth force-pushed the feature/allow-bundles-translation-path-in-commands branch from 2e06e85 to f9a6224 Compare December 2, 2023 12:35
@Jibbarth Jibbarth changed the base branch from 7.0 to 7.1 December 2, 2023 12:36
@Jibbarth
Copy link
Contributor Author

Jibbarth commented Dec 2, 2023

😓 Sorry for the code owner review requested that happened while changing base branch

@Jibbarth
Copy link
Contributor Author

Jibbarth commented Feb 5, 2024

Friendly ping @welcoMattic 👋

After re-reading it, I don't really like config key I put.

I'm open to suggestions 🙂

@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants