[Serializer] Fix deserialization_path missing using contructor #52713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Nov 24, 2023
xabbuh
approved these changes
Nov 24, 2023
|
Thank you @mtarld. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2023
…ext value twice (xabbuh) This PR was merged into the 6.3 branch. Discussion ---------- [Serializer] do not detect the deserialization_path context value twice | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT #52713 must not be applied on 6.3+ as the logic is already part of the `getAttributeDenormalizationContext()` method introduced in #46680. Commits ------- 9b027a5 do not detect the deserialization_path context value twice
This was referenced Nov 26, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to fix #44925, I used a wrong approach (#52683), and therefore introduced a bug.
This PR fixes it and solve the previous issue in a better way.