[Serializer] Provide context information from attribute for promoted properties #46680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests seems unrelated. |
ogizanagi
requested changes
Jun 15, 2022
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
|
Thanks for submitting this ❤️ I think it should target 6.2 however, as a new feature rather than a bug fix |
|
Well i guess its debatable if its a bug or feature. Since the Attribute supports to be set on properties and 5.4 is supporting php 8.0 you could say it's a bug. But I'm fine with saying this is a new feature 😅 |
ogizanagi
reviewed
Jun 17, 2022
ogizanagi
reviewed
Jun 17, 2022
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
ogizanagi
approved these changes
Jun 20, 2022
ogizanagi
approved these changes
Jun 29, 2022
| @@ -123,6 +123,14 @@ public function testLoadContexts() | |||
| $this->assertLoadedContexts($this->getNamespace().'\ContextDummy', $this->getNamespace().'\ContextDummyParent'); | |||
| } | |||
|
|
|||
| /** | |||
| * @requires PHP 8 | |||
There was a problem hiding this comment.
This @requires won't be necessary if we merge this to 6.2
There was a problem hiding this comment.
Feel free to merge it either in 4.4 (as i saw this is latest maintained version) or 6.2. Or do you need me to update this here?
There was a problem hiding this comment.
The attribute is not available in 4.4 yet.
Since @dunglas seems to agree with me this should be considered a new feature, as of PHP 8 specific feature, we'll merge it to 6.2. The rebase and changing this line is not necessary, we can do it while merging, but updating the PR to the right branch might be helpful to detect unexpected issues on the CI.
fabpot
approved these changes
Jul 3, 2022
fabpot
force-pushed
the
property-promotion-context
branch
from
1f3d272
to
c51c4e6
Compare
|
Thank you @DanielBadura. |
chalasr
added a commit
that referenced
this pull request
Jul 4, 2022
This PR was merged into the 6.2 branch. Discussion ---------- [Serializer] fix AbstractObjectNormalizer | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fixes #46680 Commits ------- fdb42bb [Serializer] fix AbstractObjectNormalizer
fabpot
added a commit
that referenced
this pull request
Jul 4, 2022
…cedNameConverterInterface::denormalize (ogizanagi) This PR was merged into the 6.2 branch. Discussion ---------- [Serializer] Cannot use Context attribute context in AdvancedNameConverterInterface::denormalize | Q | A | ------------- | --- | Branch? | 6.2 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #46680 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | N/A I realized we can't use the `Context` attribute context in an `AdvancedNameConverterInterface::denormalize`, same as spotted already in 5.4 in #46525. Also adds the missing CHANGELOG entry for #46680 Commits ------- c99082c [Serializer] Cannot use @context context in AdvancedNameConverterInterface::denormalize
This was referenced Oct 8, 2022
Merged
This was referenced Nov 22, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Nov 23, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix constructor deserialization path | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #44925 | License | MIT This fix doesn't have to be upmerged because it already has been covered by #46680. Commits ------- 272bc28 [Serializer] Fix constructor deserialization path
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Nov 23, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix constructor deserialization path | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #44925 | License | MIT This fix doesn't have to be upmerged because it already has been covered by symfony/symfony#46680. Commits ------- 272bc28763d [Serializer] Fix constructor deserialization path
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2023
…ext value twice (xabbuh) This PR was merged into the 6.3 branch. Discussion ---------- [Serializer] do not detect the deserialization_path context value twice | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT #52713 must not be applied on 6.3+ as the logic is already part of the `getAttributeDenormalizationContext()` method introduced in #46680. Commits ------- 9b027a5 do not detect the deserialization_path context value twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored some classes to using property promotion wiht
#[Context]attributes and my tests started to fail since the context was missing then. So i tried to retrieve this context at theAbstractNormalizerand added a testcase for that.I'm not sure if this is the right place for getting this metadata information and if i have overseen something.