[Serializer] Fix normalization relying on allowed attributes only #52767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtarld
commented
Nov 28, 2023
mtarld
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #52744 |
| License | MIT |
chalasr
approved these changes
Nov 28, 2023
soyuka
approved these changes
Nov 28, 2023
xabbuh
requested changes
Nov 28, 2023
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
mtarld
force-pushed
the
fix/allowed-attributes
branch
from
3652092
to
fb96f68
Compare
|
Thank you @mtarld. |
nicolas-grekas
force-pushed
the
fix/allowed-attributes
branch
from
fb96f68
to
ca16751
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Revert allowed attributes fix | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Revert #52767 and #52680, as it does not cover some specific use cases, and can't be fixed in time. I'll attempt to fix it in a better way, taking more time. Commits ------- 1dc20a8 [Serializer] Revert allowed attributes fix
This was referenced Nov 29, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.