Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Revert allowed attributes fix #52786

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Nov 29, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Revert #52767 and #52680, as it does not cover some specific use cases, and can't be fixed in time.

I'll attempt to fix it in a better way, taking more time.

@mtarld
Copy link
Contributor Author

mtarld commented Nov 29, 2023

This reopens #52673 and #49710

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have time to be back on the original issue, better avoid the regression on 6.4/7

@nicolas-grekas
Copy link
Member

Thank you @mtarld.

@nicolas-grekas nicolas-grekas merged commit 963cccd into symfony:5.4 Nov 29, 2023
7 of 11 checks passed
@mtarld mtarld deleted the fix/revert-allowed-attributes branch November 29, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants